-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode #7881
Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode #7881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
recheck |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
If nobody objects, I'll merge this in a week. |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7978 🤖 @patchback |
…n run mode (#7881) * Fix warning integrated * Update Keycloak version intergrated test * Exclude metadata from diff test * Sanity * Add fragments * typo * Add test * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove docker compose * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 001292c)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7979 🤖 @patchback |
…n run mode (#7881) * Fix warning integrated * Update Keycloak version intergrated test * Exclude metadata from diff test * Sanity * Add fragments * typo * Add test * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove docker compose * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 001292c)
@desand01 thanks for fixing this! |
…detects changes on check_mode but not in run mode (#7978) Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode (#7881) * Fix warning integrated * Update Keycloak version intergrated test * Exclude metadata from diff test * Sanity * Add fragments * typo * Add test * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove docker compose * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 001292c) Co-authored-by: desand01 <desrosiers.a@hotmail.com>
…detects changes on check_mode but not in run mode (#7979) Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode (#7881) * Fix warning integrated * Update Keycloak version intergrated test * Exclude metadata from diff test * Sanity * Add fragments * typo * Add test * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove docker compose * Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 001292c) Co-authored-by: desand01 <desrosiers.a@hotmail.com>
SUMMARY
fixes #1226
ISSUE TYPE
COMPONENT NAME
keycloak_client
ADDITIONAL INFORMATION
Client metadata should not be use when comparing desired state