Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode #7881

Merged
merged 10 commits into from
Feb 17, 2024
Merged

Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode #7881

merged 10 commits into from
Feb 17, 2024

Conversation

desand01
Copy link
Contributor

@desand01 desand01 commented Jan 22, 2024 •
edited
Loading

SUMMARY

fixes #1226

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_client

ADDITIONAL INFORMATION

Client metadata should not be use when comparing desired state

@ansibullbot
Copy link
Collaborator

cc @eikef @mattock @ndclt
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests labels Jan 22, 2024
Andre Desrosiers added 2 commits January 22, 2024 08:49
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Jan 22, 2024
felixfontein
felixfontein reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

tests/integration/targets/keycloak_client/README.md Show resolved Hide resolved
changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

recheck

@desand01 @felixfontein
Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml
b2932e7 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this in a week.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 11, 2024
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Feb 17, 2024
@felixfontein felixfontein merged commit 001292c into ansible-collections:main Feb 17, 2024
121 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 17, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/001292c780adc53e175470dee3ad6b138956bd56/pr-7881

Backported as #7978

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 17, 2024
@desand01 @patchback
Fixes #1226 - keycloak_client detects changes on check_mode but not i…
e8a1064 
…n run mode (#7881)

* Fix warning integrated

* Update Keycloak version intergrated test

* Exclude metadata from diff test

* Sanity

* Add fragments

* typo

* Add test

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove docker compose

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 001292c)
@patchback patchback bot mentioned this pull request Feb 17, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Feb 17, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/001292c780adc53e175470dee3ad6b138956bd56/pr-7881

Backported as #7979

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 17, 2024
@desand01 @patchback
Fixes #1226 - keycloak_client detects changes on check_mode but not i…
96b2be0 
…n run mode (#7881)

* Fix warning integrated

* Update Keycloak version intergrated test

* Exclude metadata from diff test

* Sanity

* Add fragments

* typo

* Add test

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove docker compose

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 001292c)
@patchback patchback bot mentioned this pull request Feb 17, 2024
Merged
@felixfontein
Copy link
Collaborator

@desand01 thanks for fixing this!

felixfontein pushed a commit that referenced this pull request Feb 17, 2024
@patchback @desand01
[PR #7881/001292c7 backport][stable-7] Fixes #1226 - keycloak_client …
7884700 
…detects changes on check_mode but not in run mode (#7978)

Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode (#7881)

* Fix warning integrated

* Update Keycloak version intergrated test

* Exclude metadata from diff test

* Sanity

* Add fragments

* typo

* Add test

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove docker compose

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 001292c)

Co-authored-by: desand01 <desrosiers.a@hotmail.com>
felixfontein pushed a commit that referenced this pull request Feb 17, 2024
@patchback @desand01
[PR #7881/001292c7 backport][stable-8] Fixes #1226 - keycloak_client …
8eec476 
…detects changes on check_mode but not in run mode (#7979)

Fixes #1226 - keycloak_client detects changes on check_mode but not in run mode (#7881)

* Fix warning integrated

* Update Keycloak version intergrated test

* Exclude metadata from diff test

* Sanity

* Add fragments

* typo

* Add test

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove docker compose

* Update changelogs/fragments/7881-fix-keycloak-client-ckeckmode.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 001292c)

Co-authored-by: desand01 <desrosiers.a@hotmail.com>
@desand01 desand01 deleted the fix-keycloak-client-issue-1226 branch April 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keycloak_client detects changes on check_mode but not in run mode
3 participants
@desand01 @ansibullbot @felixfontein