Pkgin fixes #7971
Merged
Pkgin fixes #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <felix@fontein.de>
|
If nobody objects, I'll merge this on the weekend. |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8015 🤖 @patchback |
|
@jcea thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Solve exception and spurious "changed" in pkgin * Create changelog * PEP 8 * Update changelogs/fragments/pkgin.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit dd25ddf)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8016 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Solve exception and spurious "changed" in pkgin * Create changelog * PEP 8 * Update changelogs/fragments/pkgin.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit dd25ddf)
felixfontein
pushed a commit
that referenced
this pull request
Feb 23, 2024
Pkgin fixes (#7971) * Solve exception and spurious "changed" in pkgin * Create changelog * PEP 8 * Update changelogs/fragments/pkgin.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit dd25ddf) Co-authored-by: Jesús Cea <jcea@jcea.es>
felixfontein
pushed a commit
that referenced
this pull request
Feb 23, 2024
Pkgin fixes (#7971) * Solve exception and spurious "changed" in pkgin * Create changelog * PEP 8 * Update changelogs/fragments/pkgin.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit dd25ddf) Co-authored-by: Jesús Cea <jcea@jcea.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
pkgin module raises sporadic exceptions and spurious "changed" status instead of "ok".
The reason is that modern "pkgin" can produce extra text lines beside the final "nothing to do.". We ignore those extra lines.
ISSUE TYPE
COMPONENT NAME
pkgin
ADDITIONAL INFORMATION