Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7980/74c15c12 backport][stable-8] Updates lxd_container to support new LXD API #8046

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 28, 2024

This is a backport of PR #7980 as merged into main (74c15c1).

SUMMARY

Updates the lxd_container module to work with the new LXD API which deprecates /1.0/containers and /1.0/virtual-machines and adds /1.0/instances. It tries to keep backwards compatibility with a try and catch compared to detecting the API version then determining which API endpoint to use.

It also adds support for Incus

Fixes #7853

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module/Plugin Pull Request
  • Refactoring Pull Request
  • Test Pull Request
COMPONENT NAME

lxd_container

ADDITIONAL INFORMATION

* feat: ✨ adds support for /1.0/instances endpoint

* Update changelogs/fragments/lxd-instances-api-endpoint-added.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 74c15c1)
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Feb 28, 2024
@felixfontein felixfontein merged commit d3ef55c into stable-8 Feb 28, 2024
120 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/74c15c12418bf2f7e1dcac1a88657c8aefaeeb6d/pr-7980 branch February 28, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants