Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam_limits: do not create file in check mode when it does not exist #8057

Merged
merged 1 commit into from
Mar 8, 2024
Merged

pam_limits: do not create file in check mode when it does not exist #8057

merged 1 commit into from
Mar 8, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #8050.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pam_limits

@felixfontein felixfontein mentioned this pull request Mar 3, 2024
Closed
1 task
@ansibullbot
Copy link
Collaborator

cc @giovannisciortino
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) labels Mar 3, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Mar 3, 2024
oraNod
oraNod approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 8, 2024
@felixfontein felixfontein merged commit c13bede into ansible-collections:main Mar 8, 2024
121 checks passed
@patchback Patchback
Copy link

patchback bot commented Mar 8, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/c13bede0c59916c8427f0cf3c7e4dac93ce0e419/pr-8057

Backported as #8070

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the pam_limits branch March 8, 2024 06:26
patchback bot pushed a commit that referenced this pull request Mar 8, 2024
@felixfontein @patchback
pam_limits: do not create file in check mode when it does not exist (#…
e0ac910 
…8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)
@patchback patchback bot mentioned this pull request Mar 8, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Mar 8, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/c13bede0c59916c8427f0cf3c7e4dac93ce0e419/pr-8057

Backported as #8071

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@oraNod thanks a lot for reviewing this!

patchback bot pushed a commit that referenced this pull request Mar 8, 2024
@felixfontein @patchback
pam_limits: do not create file in check mode when it does not exist (#…
a230677 
…8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)
@patchback patchback bot mentioned this pull request Mar 8, 2024
Merged
felixfontein added a commit that referenced this pull request Mar 9, 2024
@patchback @felixfontein
[PR #8057/c13bede0 backport][stable-7] pam_limits: do not create file…
ddf566a 
… in check mode when it does not exist (#8070)

pam_limits: do not create file in check mode when it does not exist (#8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Mar 9, 2024
@patchback @felixfontein
[PR #8057/c13bede0 backport][stable-8] pam_limits: do not create file…
edcb4c6 
… in check mode when it does not exist (#8071)

pam_limits: do not create file in check mode when it does not exist (#8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)

Co-authored-by: Felix Fontein <felix@fontein.de>
@patchback Patchback
Copy link

patchback bot commented Mar 10, 2024 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/c13bede0c59916c8427f0cf3c7e4dac93ce0e419/pr-8057

Backported as #8080

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 10, 2024
@felixfontein @patchback
pam_limits: do not create file in check mode when it does not exist (#…
05ecbf6 
…8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)
@patchback patchback bot mentioned this pull request Mar 10, 2024
Merged
felixfontein added a commit that referenced this pull request Mar 10, 2024
@patchback @felixfontein
[PR #8057/c13bede0 backport][stable-6] pam_limits: do not create file…
40de10b 
… in check mode when it does not exist (#8080)

pam_limits: do not create file in check mode when it does not exist (#8057)

Do not create file in check mode when it does not exist.

(cherry picked from commit c13bede)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oraNod oraNod oraNod approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) shipit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pam_limits: check mode creates empty file
3 participants
@felixfontein @ansibullbot @oraNod