Add --diff support for ldap_attrs module #8073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
added
check-before-release
felixfontein
reviewed
Mar 9, 2024
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
russoz
reviewed
Mar 10, 2024
StopMotionCuber
force-pushed
the
ldap-attrs-diff
branch
from
b9cd1cd
to
2bdae53
Compare
Have added the changelog fragment and added |
russoz
reviewed
Mar 11, 2024
StopMotionCuber
force-pushed
the
ldap-attrs-diff
branch
from
14e62f5
to
a7f8002
Compare
Co-authored-by: Felix Fontein <felix@fontein.de>
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8099 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Add --diff support for ldap_attrs module * Change diff_mode support in docstring to full * Use _attrs suffix for old and new * Add version added to ldap_attrs diff mode * Add fragment for ldap_attrs diff mode * Update fragment to include link to PR and lowercase start * Update changelogs/fragments/8073-ldap-attrs-diff.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 09cded0)
|
@StopMotionCuber thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Mar 14, 2024
…trs module (#8099) Add --diff support for ldap_attrs module (#8073) * Add --diff support for ldap_attrs module * Change diff_mode support in docstring to full * Use _attrs suffix for old and new * Add version added to ldap_attrs diff mode * Add fragment for ldap_attrs diff mode * Update fragment to include link to PR and lowercase start * Update changelogs/fragments/8073-ldap-attrs-diff.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 09cded0) Co-authored-by: StopMotionCuber <ruben.simons@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds support for the
--diffmode for theldap_attrsmodule. For the otherldapmodules this does not really make sense, asldap_searchis read-only and forldap_entrythere is only a change if the entry is not there at all (so the state is quite clear).We would like to use this kind of feature for internal use of the module.
ISSUE TYPE
COMPONENT NAME
ldap_attrsADDITIONAL INFORMATION
Right now, the module does not search for all available attributes at the same time. The
--diffmode therefore has difficulties if we are only adding/deleting single values of a multi value attribute to detect what was there before and what would be the final state.With
--exact, we're replacing everything, therefore this issue is not present there.I'm not sure about the policy on this repo, whether a potentially misleading diff is worse than none. Could also change that to not use "before" and "after", but going for "prepared" and a message like "
<key>: Added value(s) [<value1>, <value2>]" for thepresentorabsentstate. We are only using theexact` state, so partial diff support only for that state would be fine to us.Furthermore, attributes are not shown in the
--diffif they are on the server, but not used within the module (probably not an issue).Yeah well, as you can see from the longish message here I also want to get the discussion going. I'll add the fragment as soon as the discussions here are cleared up and the path for the PR is more clear.