Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aix_filesystem): remove extra param from running lsvg #8176

Merged
merged 3 commits into from Apr 9, 2024
Merged

fix(aix_filesystem): remove extra param from running lsvg #8176

merged 3 commits into from Apr 9, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Apr 2, 2024 •
edited

SUMMARY

closes #8151

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/aix_filesystem.py

ADDITIONAL INFORMATION

From the lsvg command examples documentation

  • To display the names of all active volume groups is command lsvg -o
  • To display the names of all volume groups within the system is just lsvg

so I removed the extra param from running lsvg.

@ansibullbot
Copy link
Collaborator

cc @MorrisA @bcoca @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @wtcross
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 2, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Apr 2, 2024
felixfontein
felixfontein reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/aix_filesystem.py Show resolved Hide resolved
changelogs/fragments/8151-fix-lsvg_cmd-failed.yml Outdated Show resolved Hide resolved
@shenxianpeng @felixfontein
Update 8151-fix-lsvg_cmd-failed.yml
1c4188a 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 9, 2024
@felixfontein felixfontein merged commit 8491bf7 into ansible-collections:main Apr 9, 2024
133 checks passed
@patchback Patchback
Copy link

patchback bot commented Apr 9, 2024 •
edited

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/8491bf7b49c42aca0b49a86ed31dba0a4d90dfcb/pr-8176

Backported as #8208

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 9, 2024
@shenxianpeng @patchback
fix(aix_filesystem): remove extra param from running lsvg (#8176)
497d94f 
* fix(aix_filesystem): remove extra param from running lsvg

* chore: add new line to changlog file

* Update 8151-fix-lsvg_cmd-failed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8491bf7)
@patchback patchback bot mentioned this pull request Apr 9, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Apr 9, 2024 •
edited

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/8491bf7b49c42aca0b49a86ed31dba0a4d90dfcb/pr-8176

Backported as #8209

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@shenxianpeng thanks for your contribution!
@kairoaraujo thanks for reviewing this!

patchback bot pushed a commit that referenced this pull request Apr 9, 2024
@shenxianpeng @patchback
fix(aix_filesystem): remove extra param from running lsvg (#8176)
8be5895 
* fix(aix_filesystem): remove extra param from running lsvg

* chore: add new line to changlog file

* Update 8151-fix-lsvg_cmd-failed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8491bf7)
@patchback patchback bot mentioned this pull request Apr 9, 2024
Merged
felixfontein pushed a commit that referenced this pull request Apr 9, 2024
@patchback @shenxianpeng
[PR #8176/8491bf7b backport][stable-7] fix(aix_filesystem): remove ex…
882ce25 
…tra param from running lsvg (#8208)

fix(aix_filesystem): remove extra param from running lsvg (#8176)

* fix(aix_filesystem): remove extra param from running lsvg

* chore: add new line to changlog file

* Update 8151-fix-lsvg_cmd-failed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8491bf7)

Co-authored-by: Peter Shen <xianpeng.shen@gmail.com>
felixfontein pushed a commit that referenced this pull request Apr 9, 2024
@patchback @shenxianpeng
[PR #8176/8491bf7b backport][stable-8] fix(aix_filesystem): remove ex…
39dd596 
…tra param from running lsvg (#8209)

fix(aix_filesystem): remove extra param from running lsvg (#8176)

* fix(aix_filesystem): remove extra param from running lsvg

* chore: add new line to changlog file

* Update 8151-fix-lsvg_cmd-failed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8491bf7)

Co-authored-by: Peter Shen <xianpeng.shen@gmail.com>
@shenxianpeng shenxianpeng deleted the fix_aix_filesystem branch April 9, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairoaraujo kairoaraujo kairoaraujo approved these changes

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aix_filesystem: _validate_vg not passing vg name to lsvg_cmd
4 participants
@shenxianpeng @ansibullbot @felixfontein @kairoaraujo