Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate hipchat callback #8189

Merged
merged 2 commits into from Apr 20, 2024
Merged

Deprecate hipchat callback #8189

merged 2 commits into from Apr 20, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #8184.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hipchat callback

@felixfontein felixfontein added the backport-8 Automatically create a backport for the stable-8 branch label Apr 4, 2024
@felixfontein felixfontein mentioned this pull request Apr 4, 2024
Closed
1 task
@ansibullbot ansibullbot added callback callback plugin feature This issue/PR relates to a feature request has_issue plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 4, 2024
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 5, 2024
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 6, 2024
@felixfontein
Copy link
Collaborator Author

If nobody objects I'll merge this in a week.

@felixfontein felixfontein merged commit 1bbef58 into ansible-collections:main Apr 20, 2024
132 of 133 checks passed
@patchback Patchback
Copy link

patchback bot commented Apr 20, 2024 •
edited

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/1bbef5884488901a7e5e50c719e2d97c1c9452d6/pr-8189

Backported as #8240

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the hipchat branch April 20, 2024 07:24
patchback bot pushed a commit that referenced this pull request Apr 20, 2024
@felixfontein @patchback
Deprecate hipchat callback (#8189)
8e3fa07 
* Deprecate hipchat callback.

* Avoid duplicate 'callback' key.

(cherry picked from commit 1bbef58)
@patchback patchback bot mentioned this pull request Apr 20, 2024
Merged
felixfontein added a commit that referenced this pull request Apr 20, 2024
@patchback @felixfontein
[PR #8189/1bbef588 backport][stable-8] Deprecate hipchat callback (#8240
6f60692 
)

Deprecate hipchat callback (#8189)

* Deprecate hipchat callback.

* Avoid duplicate 'callback' key.

(cherry picked from commit 1bbef58)

Co-authored-by: Felix Fontein <felix@fontein.de>
aretrosen pushed a commit to aretrosen/community.general that referenced this pull request Apr 22, 2024
@felixfontein @aretrosen
Deprecate hipchat callback (ansible-collections#8189)
4a16f39 
* Deprecate hipchat callback.

* Avoid duplicate 'callback' key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch callback callback plugin feature This issue/PR relates to a feature request has_issue plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate hipchat callback
2 participants
@felixfontein @ansibullbot