fix: sudosu not working on some BSD machines

[lekoOwO]

SUMMARY

The original sudosu does not work on some BSD machines and some versions of linux machine as the argument of su differs .

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

become.sudosu

ADDITIONAL INFORMATION

[ansibullbot]

cc @dagwieers
click here for bot help

[lekoOwO]

BTW, if /bin/sh is prefered, we should pass -s /bin/sh to su.

The original version passes /bin/sh without -s, thus on many su it does not work.

[felixfontein]

Thanks for your contribution! Please note that you need to add a changelog fragment, and that the unit tests are failing (https://github.com/ansible-collections/community.general/blob/main/tests/unit/plugins/become/test_sudosu.py).

Also it seems to me that this is potentially a larger change that might break some use-cases on other systems. I'm wondering whether the switch between the current and the new behavior should maybe be controlled by a toggle?

(The /bin/sh comes from the currently selected shell plugin, so hardcoding that is out of the question. That would break other mechanisms.)

[lekoOwO]

ummmm the unit test is failing because it is asserting the original command which is not working on all system... Maybe we should change the unit test?

[lekoOwO]

I'm wondering whether the switch between the current and the new behavior should maybe be controlled by a toggle?

That sounds good to me.