Add support for docker-v2 protocol in Keycloak modules #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
Update changelog fragment to reviewers suggestion, add refrence to issue and pull request Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
needs_ci
|
If nobody objects, I'll merge this in ~a week. |
felixfontein
removed
the
check-before-release
felixfontein
merged commit a5b2b5c
into
ansible-collections:main
132 of 133 checks passed
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8239 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Add support for docker-v2 protocol in Keycloak modules * use dash instead of underscore for the docker-v2 * Update documentation * Add changelog fragment * fix missing whitespace around operator * Update changelogs/fragments/8215-add-docker-v2-protocol.yml Update changelog fragment to reviewers suggestion, add refrence to issue and pull request Co-authored-by: Felix Fontein <felix@fontein.de> * Add documentation about adding docker-v2 value in community general 8.6.0 --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a5b2b5c)
|
@anderssh thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Apr 20, 2024
…ocol in Keycloak modules (#8239) Add support for docker-v2 protocol in Keycloak modules (#8216) * Add support for docker-v2 protocol in Keycloak modules * use dash instead of underscore for the docker-v2 * Update documentation * Add changelog fragment * fix missing whitespace around operator * Update changelogs/fragments/8215-add-docker-v2-protocol.yml Update changelog fragment to reviewers suggestion, add refrence to issue and pull request Co-authored-by: Felix Fontein <felix@fontein.de> * Add documentation about adding docker-v2 value in community general 8.6.0 --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a5b2b5c) Co-authored-by: Anders Stiksrud Helmen <anders.s.helmen@gmail.com>
aretrosen
pushed a commit
to aretrosen/community.general
that referenced
this pull request
Apr 22, 2024
…ctions#8216) * Add support for docker-v2 protocol in Keycloak modules * use dash instead of underscore for the docker-v2 * Update documentation * Add changelog fragment * fix missing whitespace around operator * Update changelogs/fragments/8215-add-docker-v2-protocol.yml Update changelog fragment to reviewers suggestion, add refrence to issue and pull request Co-authored-by: Felix Fontein <felix@fontein.de> * Add documentation about adding docker-v2 value in community general 8.6.0 --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request introduces the addition of the "docker-v2" protocol support to the
keycloak_client,keycloak_clientscope, andkeycloak_clienttemplatemodules within the community.general collection. The "docker-v2" protocol is a valid and supported option in Keycloak, which is crucial for configurations involving Docker registry authentication, among others. Fixes #8215.ISSUE TYPE
COMPONENT NAME
keycloak_clientkeycloak_clientscopekeycloak_clienttemplateADDITIONAL INFORMATION
I have enhanced the
protocolparameter across thekeycloak_client,keycloak_clientscope, andkeycloak_clienttemplatemodules to include the "docker-v2" option. It's important to note that the existing protocol choices varied across different modules — some were limited to['openid-connect', 'saml'], while others used Python constants to define the choices. I've respected the existing structure and conventions in each module, only extending them to include "docker-v2".For instance, if a module's protocol choices were previously defined as:
I have updated this to
And similarly, for modules using Python constants to define protocol choices, I've appended "docker-v2" to the existing list without altering the existing structure.
The documentation for each affected module has been updated to include "docker-v2" as a valid protocol option.
The modifications were tested to confirm that the "docker-v2" protocol is recognized and behaves as expected across the updated modules. I encourage further testing by the community to validate these changes across various usage scenarios.
I have not verified the potential error message from the Keycloak API when this option is used when the keycloak server has not activated the docker-v2 protocol, (disabled by default and enabled by running
bin/standalone.sh|bat -Dkeycloak.profile.feature.docker=enabledstarting the service, see (https://www.keycloak.org/server/features).