Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt_rpm: deprecate behavior of state=present and state=installed #8285

Merged
merged 2 commits into from
May 1, 2024
Merged

apt_rpm: deprecate behavior of state=present and state=installed #8285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
821eda8
Deprecate behavior of state=present and state=installed.
felixfontein Apr 26, 2024
4894d40
Fix changelog fragment.
felixfontein Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelogs/fragments/8285-apt_rpm-state-deprecate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
deprecated_features:
- "apt_rpm - the behavior of ``state=present`` and ``state=installed`` is deprecated and will change in community.general 11.0.0.
Right now the module will upgrade a package to the latest version if one of these two states is used. You should explicitly
use ``state=latest`` if you want this behavior, and switch to ``state=present_not_latest`` if you do not want to upgrade the
package if it is already installed. In community.general 11.0.0 the behavior of ``state=present`` and ``state=installed`` will
change to that of ``state=present_not_latest`` (https://github.com/ansible-collections/community.general/issues/8217,
https://github.com/ansible-collections/community.general/pull/8285)."
12 changes: 12 additions & 0 deletions plugins/modules/apt_rpm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,18 @@ def main():
module.fail_json(msg="cannot find /usr/bin/apt-get and/or /usr/bin/rpm")

p = module.params
if p['state'] in ['installed', 'present']:
module.deprecate(
'state=%s currently behaves unexpectedly by always upgrading to the latest version if'
' the package is already installed. This behavior is deprecated and will change in'
' community.general 11.0.0. You can use state=latest to explicitly request this behavior'
' or state=present_not_latest to explicitly request the behavior that state=%s will have'
' in community.general 11.0.0, namely that the package will not be upgraded if it is'
' already installed.' % (p['state'], p['state']),
version='11.0.0',
collection_name='community.general',
)

modified = False
output = ""

Expand Down