Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdRunner format as_list - check for min_len and max_len #8288

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 28, 2024

SUMMARY

Add checks for minimum and maximum length in cmd_runner_fmt.as_list()

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/cmd_runner.py

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) tests tests unit tests/unit needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 28, 2024
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 28, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please remember the changelog fragment :)

plugins/module_utils/cmd_runner.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 85f9d89 into ansible-collections:main Apr 29, 2024
129 of 133 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 29, 2024
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

@russoz russoz deleted the cmdrunner-list-len-limits branch April 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants