Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gandi_livedns): support personal access tokens #8337

Merged
merged 2 commits into from
May 18, 2024
Merged

feat(gandi_livedns): support personal access tokens #8337

merged 2 commits into from
May 18, 2024

Conversation

gilbsgilbs
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gandi_livedns

ADDITIONAL INFORMATION

Should be self-explanatory.

@ansibullbot
Copy link
Collaborator

cc @gthiemonge
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels May 11, 2024
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label May 11, 2024
felixfontein
felixfontein reviewed May 11, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/module_utils/gandi_livedns_api.py Outdated Show resolved Hide resolved
plugins/modules/gandi_livedns.py Show resolved Hide resolved
plugins/modules/gandi_livedns.py Show resolved Hide resolved
plugins/modules/gandi_livedns.py Outdated Show resolved Hide resolved
plugins/modules/gandi_livedns.py Outdated Show resolved Hide resolved
@gilbsgilbs
Copy link
Contributor Author

gilbsgilbs commented May 11, 2024 •
edited

Thanks for the prompt review and spot-on suggestions @felixfontein . Very much appreciated. Should be fixed.

felixfontein
felixfontein approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If nobody objects, I'll merge this in ~a week.

russoz
russoz approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 18, 2024
@felixfontein felixfontein merged commit a409f8f into ansible-collections:main May 18, 2024
132 of 133 checks passed
@felixfontein
Copy link
Collaborator

@gilbsgilbs thanks for contributing this!
@russoz thanks for reviewing this one as well :)

@gilbsgilbs gilbsgilbs deleted the gandi-pat branch May 18, 2024 13:44
austinlucaslake pushed a commit to austinlucaslake/community.general that referenced this pull request May 25, 2024
@gilbsgilbs @austinlucaslake
feat(gandi_livedns): support personal access tokens (ansible-collecti…
c2f9b33 
…ons#8337)

* fix(gandi_livedns): fix unsafe conditionals in tests

* feat(gandi_livedns): support personal access tokens

Fixes ansible-collections#7639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gandi DNS module silently fails when using bearer tokens
4 participants
@gilbsgilbs @ansibullbot @felixfontein @russoz