Fix sanitize for keycloak_identitiy_provider. #8355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo13
force-pushed
the
keycloak-idp-sanitize
branch
2 times, most recently
from
e43e2eb
to
498dee3
Compare
ansibullbot
added
bug
apollo13
force-pushed
the
keycloak-idp-sanitize
branch
from
498dee3
to
0212226
Compare
ansibullbot
added
integration
felixfontein
added
the
check-before-release
felixfontein
added
backport-6
backport-7
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
May 15, 2024
felixfontein
merged commit fabf626
into
ansible-collections:main
132 of 133 checks passed
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #8369 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 15, 2024
* Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8370 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 15, 2024
* Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8371 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 15, 2024
* Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626)
felixfontein
removed
the
check-before-release
|
@apollo13 thanks a lot for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
May 15, 2024
…titiy_provider. (#8371) Fix sanitize for keycloak_identitiy_provider. (#8355) * Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626) Co-authored-by: Florian Apolloner <florian@apolloner.eu>
felixfontein
pushed a commit
that referenced
this pull request
May 15, 2024
…titiy_provider. (#8370) Fix sanitize for keycloak_identitiy_provider. (#8355) * Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626) Co-authored-by: Florian Apolloner <florian@apolloner.eu>
felixfontein
pushed a commit
that referenced
this pull request
May 15, 2024
…titiy_provider. (#8369) Fix sanitize for keycloak_identitiy_provider. (#8355) * Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit fabf626) Co-authored-by: Florian Apolloner <florian@apolloner.eu>
v1v
added a commit
to v1v/community.general
that referenced
this pull request
May 16, 2024
…t-flag * upstream/main: Add REUSE badge (ansible-collections#8365) Initial commit for django modutils and django_command module (ansible-collections#8349) [opentelemetry][callback] Add support for http exporter (ansible-collections#8321) Fix sanitize for keycloak_identitiy_provider. (ansible-collections#8355)
austinlucaslake
pushed a commit
to austinlucaslake/community.general
that referenced
this pull request
May 25, 2024
* Fix sanitize for keycloak_identitiy_provider. * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The sanitize function did not properly sanitize the client secret.
ISSUE TYPE
COMPONENT NAME
keycloak_identity_provider
ADDITIONAL INFORMATION