Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab modules): remove basic auth #8405

Conversation

lgatellier
Copy link
Contributor

SUMMARY

This PR removes ability to authenticate against GitLab API using Basic Auth (deprecated in #8383).

Note : This is a breaking change.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gitlab_deploy_key
gitlab_project_badge
gitlab_hook
gitlab_project_variable
gitlab_label
gitlab_instance_variable
gitlab_project_members
gitlab_project_access_token
gitlab_group_access_token
gitlab_merge_request
gitlab_branch
gitlab_project
gitlab_milestone
gitlab_runner
gitlab_protected_branch
gitlab_group_variable
gitlab_user
gitlab_group_members
gitlab_group
gitlab_issue

ADDITIONAL INFORMATION

N/A

@lgatellier lgatellier force-pushed the feat/remove-gitlab-basic-auth branch from 8629d66 to ddb7fcc Compare May 22, 2024 16:20
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request gitlab module_utils module_utils plugins plugin (any type) labels May 22, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

changelogs/fragments/8405-gitlab-remove-basic-auth.yml Outdated Show resolved Hide resolved
changelogs/fragments/8405-gitlab-remove-basic-auth.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added breaking_change This PR contains a breaking change that MUST NOT be backported check-before-release PR will be looked at again shortly before release and merged if possible. labels May 22, 2024
BREAKING CHANGE : Remove basic auth against GitLab API
@lgatellier lgatellier force-pushed the feat/remove-gitlab-basic-auth branch from ddb7fcc to 4f9aee9 Compare May 24, 2024 23:07
@felixfontein felixfontein merged commit 58ce19d into ansible-collections:main Jun 1, 2024
132 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 1, 2024
@felixfontein
Copy link
Collaborator

@lgatellier thanks for your contribution!

@lgatellier lgatellier deleted the feat/remove-gitlab-basic-auth branch June 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported feature This issue/PR relates to a feature request gitlab module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants