Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible_galaxy_install: add upgrade feature #8431

Merged
merged 4 commits into from
Jun 1, 2024
Merged

ansible_galaxy_install: add upgrade feature #8431

merged 4 commits into from
Jun 1, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 28, 2024

SUMMARY

Add upgrade feature.

Fixes #8351

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible_galaxy_install

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels May 28, 2024
@russoz russoz changed the title add upgrade feature ansible_galaxy_install: add upgrade feature May 28, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels May 30, 2024
felixfontein
felixfontein reviewed Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/ansible_galaxy_install.py Outdated Show resolved Hide resolved
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 1, 2024
@felixfontein felixfontein merged commit d46e12e into ansible-collections:main Jun 1, 2024
132 checks passed
@patchback Patchback
Copy link

patchback bot commented Jun 1, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/d46e12e2809f939dc433fa34335e31c6999d6750/pr-8431

Backported as #8451

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Jun 1, 2024
@russoz @patchback
ansible_galaxy_install: add upgrade feature (#8431)
4aa9d18 
* add upgrade feature

* add changelog frag

* Update plugins/modules/ansible_galaxy_install.py

* Update plugins/modules/ansible_galaxy_install.py

(cherry picked from commit d46e12e)
@patchback patchback bot mentioned this pull request Jun 1, 2024
Merged
felixfontein pushed a commit that referenced this pull request Jun 1, 2024
@patchback @russoz
[PR #8431/d46e12e2 backport][stable-9] ansible_galaxy_install: add up…
f227038 
…grade feature (#8451)

ansible_galaxy_install: add upgrade feature (#8431)

* add upgrade feature

* add changelog frag

* Update plugins/modules/ansible_galaxy_install.py

* Update plugins/modules/ansible_galaxy_install.py

(cherry picked from commit d46e12e)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the 8351-galaxy-upgrade branch June 1, 2024 23:01
@bluikko
Copy link
Contributor

bluikko commented Jul 3, 2024 •
edited
Loading

Previously I installed modules using ansible.builtin.shell and changed_when: output.stdout is search(' successfully').
Any opinions if that is a major change or could be easily added to the module to avoid changed=true always when state=latest, and to only return changed=true when something was actually updated?

Will try to take a look at this myself but it could take "a while".

Edited: nevermind was looking at the force argument help text.
All is good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible_galaxy_install has no update functionality that reports only updated collections as changed
4 participants
@russoz @felixfontein @bluikko @ansibullbot