-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty printed dashboard export #257
Comments
Hi @kongslund, solution A is good and a PR is welcome ! Thanks 🙏🏻 ! |
kongslund
added a commit
to kongslund/community.grafana
that referenced
this issue
Jul 4, 2022
rrey
pushed a commit
to kongslund/community.grafana
that referenced
this issue
Jul 10, 2022
rrey
pushed a commit
that referenced
this issue
Jul 17, 2022
Just release v1.5.1 which include the fix for this issue. It should be available on Galaxy soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SUMMARY
Support exporting a dashboard with pretty printed JSON so that it becomes easier to compare changes with the previous version.
ISSUE TYPE
COMPONENT NAME
grafana_dashboard
ADDITIONAL INFORMATION
Often when I export dashboards, I have a need to compare them with previous versions.
I use the
grafana_dashboard
module for exporting the dashboards. The current JSON output is compact and not so easy to compare in a diff, so I have an additional step of pretty printing each exported dashboard file.It would be more convenient for this use case if
grafana_dashboard
supports pretty printing out of the box.I see two possible approaches to introducing this:
A) Change
grafana_dashboard
to always export dashboards as pretty printed. I prefer this one.B) Add a module option
export_style
which determines if the resulting JSON should be compact as today or pretty printed. The two allowed values would becompact
(default) andpretty
.Example:
Would there be interest if I create a PR for either approach A or B?
The text was updated successfully, but these errors were encountered: