Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashi_vault - [env] Update VAULT_NAMESPACE to match guidelines & add INI #14

Closed
briantist opened this issue Dec 6, 2020 · 0 comments · Fixed by #25
Closed

hashi_vault - [env] Update VAULT_NAMESPACE to match guidelines & add INI #14

briantist opened this issue Dec 6, 2020 · 0 comments · Fixed by #25
Assignees
@briantist
Labels
enhancement New feature or request
Projects
Environment Variable Standardization
Milestone
v0.2.0

Comments

@briantist
Copy link
Collaborator

SUMMARY

See #10

VAULT_NAMESPACE is an environment variable used by the Vault CLI. I'm proposing the following change:

  • Add ANSIBLE_HASHI_VAULT_NAMESPACE to env: in spec
  • Add INI value as well
  • Process VAULT_NAMESPACE as a fallback to populate the option when it hasn't been set via any other means.

ℹ This change is not breaking because lowering the precedence of the existing env var doesn't raise any existing value's precedence (there's no other env var or INI value currently).

ISSUE TYPE
  • Feature Request
COMPONENT NAME

hashi_vault.py

ANSIBLE VERSION
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
@briantist briantist added the enhancement New feature or request label Dec 6, 2020
briantist added a commit to briantist/community.hashi_vault that referenced this issue Dec 12, 2020
@briantist
Update argspec for 'namespace' parameter ansible-collections#14
c636e62 
- Add `ANSIBLE_HASHI_VAULT_NAMESPACE` env var to argspec
- Move `VAULT_NAMESPACE` env var to `LOW_PRECEDENCE_ENV_VAR_OPTIONS`
- Add new INI option for `namespace`
@briantist briantist moved this from To do to In progress in Environment Variable Standardization Dec 12, 2020
@briantist briantist mentioned this issue Dec 12, 2020
Merged
@briantist briantist added this to the v0.2.0 milestone Dec 13, 2020
@briantist briantist self-assigned this Dec 13, 2020
briantist added a commit that referenced this issue Dec 14, 2020
@briantist
hashi_vault - parameter env var changes for token and namespace (#25)
052c724 
* Update argspec for 'namespace' parameter #14

- Add `ANSIBLE_HASHI_VAULT_NAMESPACE` env var to argspec
- Move `VAULT_NAMESPACE` env var to `LOW_PRECEDENCE_ENV_VAR_OPTIONS`
- Add new INI option for `namespace`

* Update token parameter handling #16

- Add `ANSIBLE_HASHI_VAULT_TOKEN` env var in argspec
- Move `VAULT_TOKEN` env var to `LOW_PRECEDENCE_ENV_VAR_OPTIONS`

* Add changelog fragment for #25

* Add issue URL to changelog fragment
@briantist briantist moved this from In progress to Done in Environment Variable Standardization Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briantist briantist

Labels
enhancement New feature or request
Projects
Environment Variable Standardization
Done
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

hashi_vault - parameter env var changes for token and namespace briantist/community.hashi_vault
1 participant
@briantist