Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove venv testing hack #45

Merged
merged 1 commit into from Jan 9, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Resurrection of #30. Removes testing hack.

See ansible/ansible#73000 (comment) for context.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #45 (136ef72) into main (0b564cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   61.41%   61.41%           
=======================================
  Files           1        1           
  Lines         254      254           
  Branches       45       45           
=======================================
  Hits          156      156           
  Misses         83       83           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b564cb...136ef72. Read the comment docs.

Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! I'll let you do the honors of merging when you're ready @felixfontein

@felixfontein
Copy link
Contributor Author

@briantist thanks! Unfortunately I don't have commit rights for this repo, so I can't :)

@briantist
Copy link
Collaborator

@briantist thanks! Unfortunately I don't have commit rights for this repo, so I can't :)

Oops! didn't realize, I can do so just say the word (wasn't sure if you wanted to make any other changes)

@briantist briantist merged commit 9c9b792 into ansible-collections:main Jan 9, 2021
@felixfontein felixfontein deleted the test-venv branch January 9, 2021 21:49
@briantist briantist added the tests Adds or modifies tests label Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Adds or modifies tests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants