Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Handle invalid kubeconfig parsing error #119

Merged
merged 1 commit into from Jun 16, 2020

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 3, 2020

SUMMARY

Provide message to user about invalid or empty kubeconfig
by handling exception raised by kubernetes Python API

Fixes: #90

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/common.py

Copy link
Collaborator

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking nit

@geerlingguy
Copy link
Collaborator

Quick q — will this pass the new flake8 test in #123? Can you rebase the PR?

Provide message to user about invalid or empty kubeconfig
by handling exception raised by kubernetes Python API

Fixes: #90

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #119 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   42.85%   42.56%   -0.29%     
==========================================
  Files           3        3              
  Lines         539      545       +6     
  Branches      110      110              
==========================================
+ Hits          231      232       +1     
- Misses        265      270       +5     
  Partials       43       43              
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 38.20% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e92889...d437d88. Read the comment docs.

@Akasurde Akasurde merged commit 3004c8d into ansible-collections:master Jun 16, 2020
@Akasurde Akasurde deleted the i90 branch June 16, 2020 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants