This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
raw: Handle exception raised by underlying APIs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kind can be provided by number of ways. It is diffcult to find all cases. So, handle exceptions raised by underlying APIs and provide good error message to user. Fixes: ansible/ansible#63652 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
fabianvf
reviewed
Aug 5, 2020
| @@ -175,7 +176,7 @@ def execute_module(self): | |||
| continue | |||
| kind = definition.get('kind', self.kind) | |||
| api_version = definition.get('apiVersion', self.api_version) | |||
| if kind.endswith('List'): | |||
| if kind and kind.endswith('List'): | |||
There was a problem hiding this comment.
I think if kind isn't defined here we're broken anyway, this should have been validated earlier. We could add an additional failout here if either kind or api_version aren't defined
fabianvf
approved these changes
Aug 5, 2020
|
@geerlingguy and @willthames -- any thoughts here? |
tima
added
has_issue
willthames
approved these changes
Aug 10, 2020
|
Agree with @fabianvf's comments but this is a good change without those revisions, they would just improve it further (so not a blocker for me) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
kind can be provided by number of ways. It is diffcult to
find all cases. So, handle exceptions raised by underlying
APIs and provide good error message to user.
Fixes: ansible/ansible#63652
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/raw.py