k8s_*: Add support for vaulted kubeconfig and src #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 41.90% 42.80% +0.90%
==========================================
Files 3 4 +1
Lines 556 605 +49
Branches 114 121 +7
==========================================
+ Hits 233 259 +26
- Misses 279 298 +19
- Partials 44 48 +4
Continue to review full report at Codecov.
|
|
@sivel Could you please review this? Thanks. |
Akasurde
force-pushed
the
k8s_info_action
branch
3 times, most recently
from
72596f5
to
fb38caa
Compare
Akasurde
changed the title
plugins/action/k8s_info.py
Outdated
| result = super(ActionModule, self).run(tmp, task_vars) | ||
| del tmp # tmp no longer has any effect | ||
|
|
||
| new_module_args = self._task.args.copy() |
There was a problem hiding this comment.
Is there any possibility this would need to be a deepcopy() since some of the k8s structures can get complex and have depth? (I genuinely don't know)
@fabianvf @geerlingguy thoughts?
There was a problem hiding this comment.
For k8s_info specifically there aren't nested parameters accepted, but for anything that supports the resource_definition parameter it could be a concern
|
Also addresses #70 I believe |
* User can provide vaulted kubeconfig * User can use src files from roles/files Partially fixes ansible-collections#38 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
k8s_info_action
branch
from
fb38caa
to
a4afc0d
Compare
SUMMARY
Partially fixes #38
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
plugins/action/k8s_info.py