This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Wait conditions #35
Merged
Wait conditions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing would be fixed by #34 |
willthames
force-pushed
the
wait_conditions
branch
from
54876ef
to
c5a2d2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 43.33% 43.22% -0.11%
==========================================
Files 3 3
Lines 540 539 -1
Branches 109 109
==========================================
- Hits 234 233 -1
Misses 263 263
Partials 43 43
Continue to review full report at Codecov.
|
willthames
force-pushed
the
wait_conditions
branch
from
c5a2d2b
to
c05d6fd
Compare
fabianvf
reviewed
Feb 21, 2020
Ensure that Deployments and Daemonsets properly await all replicas to be available. Correctly handles the subtle edge case when a service account no longer exists. Note that this will dramatically slow Daemonset updates
willthames
force-pushed
the
wait_conditions
branch
from
c05d6fd
to
35ffd0e
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Improve k8s Deployment and Daemonset wait conditions
Ensure that Deployments and Daemonsets properly await
all replicas to be available. Correctly handles the
subtle edge case when a service account no longer exists.
Note that this will dramatically slow Daemonset updates
ISSUE TYPE
COMPONENT NAME
k8s