Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Remove ANSIBLE_METADATA #95

Merged
merged 1 commit into from May 14, 2020

Conversation

orjan
Copy link
Contributor

@orjan orjan commented May 14, 2020

SUMMARY

The meta data field is deprecated and is not used anymore.
See ansible-collections/overview#57 for more details.

Fixes #91

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

all

The meta data field is deprecated and is not used anymore.

See ansible-collections/overview#57 for more details.
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #95 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   43.33%   43.22%   -0.11%     
==========================================
  Files           3        3              
  Lines         540      539       -1     
  Branches      109      109              
==========================================
- Hits          234      233       -1     
  Misses        263      263              
  Partials       43       43              
Impacted Files Coverage Δ
...ctions/community/kubernetes/plugins/modules/k8s.py 90.00% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3d2fc...f45d332. Read the comment docs.

@geerlingguy geerlingguy self-requested a review May 14, 2020 14:12
Copy link
Collaborator

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one error in the sanity test that is not related to this PR (it's failing in the cron CI run too):

ERROR: Found 1 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/k8s_info.py:147:12: collection-invalid-deprecated-version: Invalid deprecated version ('2.13') found in call to Display.deprecated or AnsibleModule.deprecate

Since that's not a blocker, I approve this PR as it resolves #91.

@geerlingguy geerlingguy merged commit 4e40ac3 into ansible-collections:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants