Extra inventory info #113
Extra inventory info #113
Conversation
+ domain.info() + domain.XMLDesc() + domain.guestInfo() (when available) + domain.interfaceAddresses() (when available)
There was a problem hiding this comment.
@dseeley hi, thanks for the PR!
I'm not a libvirt user / maintainer, so one minor general thing from me
|
There are integration tests for this plugin in |
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Gah, sorry @dseeley, I think I somehow added that suggestion from @Andersson007 into your branch... I should stick to the command line! I'll squash it down and out once it merges, but you might need to pull from your own repo before you make any more changes... |
No worries, not a problem! (I had assumed that the PR reference was pulled from the prefix in the name of the fragment?) |
I'm not familiar with the testing strategy, but I can have a look. From what I can gather, it appears that the existing inventory test simply tests that the plugin doesn't fail. |
Ah, got it, thanks!
|
|
@Andersson007 @dseeley I will definitely test this myself before we merge it, just running short on time at the moment. At a glance, there is some filter work that I think would benefit from this. |
@csmart great, thanks! No rush. Trust your judgment:) If no breaking changes, i'm personally OK with any improvements:) |
|
@dseeley thanks, this works and looks pretty handy. I feel like we do need to probably set up some test cases for this, to make sure each distro will support the elements you're trying to extract. Did you have any luck with constructing a test? |
|
BTW we have the Integration test quick start guide. May be helpful for understanding. |
It seems the current CI integration test for inventory_libvirt is Is the expectation to port the existing 'runme.sh' test to standard CI integration tests? |
|
@dseeley it looks like the current test just does a simple inventory list at |
|
@dseeley any chance you could do a rebase and force push on this for me? Then I think we can merge it in. Cheers! |
|
Thanks! |
* main: Extra inventory info (ansible-collections#113)
* main: Extra inventory info (ansible-collections#113)
* modules_virt_additions: Extra inventory info (ansible-collections#113)
SUMMARY
Add more guest information to the community.libvirt.libvirt inventory plugin, in keeping with similar such cloud modules. Include the return from the
info(),XMLDesc(),guestInfo()andinterfaceAddresses()libvirt functions.ISSUE TYPE
COMPONENT NAME
libvirt
ADDITIONAL INFORMATION
Many cloud inventory modules include substantial information about the estate being queried; this change goes some way to adding extra such information. As well as the actual XML that defines each guest, this adds the disk topology and the guest IP addresses (the latter two require that guest is powered on, qemu-guest-agent is installed and the org.qemu.guest_agent.0 channel is configured (failure is graceful in the even that these are not true).