Netscaler_nitro_request should do url-/percent-encoding in the code instead of expecting already-encoded params #53
Labels
affects_1
feature
This issue/PR relates to a feature request
module
module
needs_triage
plugins
plugin (any type)
SUMMARY
As discussed in #52 , the module currently expects parameters to be url-/percent-encoded in the play (either hardcoded or through jinja-templating), whilst it would make more sense to do this in the module itself (making them easier to read and write).
ISSUE TYPE
COMPONENT NAME
netscaler_nitro_request
ADDITIONAL INFORMATION
Because of the weirdness that is the netscaler API, some parameters need to be url-encoded, whilst others don't. Currently, this is left up to the user: the code only builds the correct query, but doesn't do any parsing of the parameter-strings themselves. This makes for pretty confusing plays, where you have parameters that need
{{ myvar | urlencode | replace('/', '%2F') }}
and others don't.It would make more sense to decide and do this in the code, making writing tasks a lot easier (as you don't need to go verify if this particular param needs encoding or not).
However, since changing this would be a backwards incompatible change, we'll have to feature flag this option, as kindly and correctly suggested by @felixfontein.
Example of how current tasks look:
Example of how this would look with the feature flag:
The text was updated successfully, but these errors were encountered: