Prepare un-flatmapping #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
prepare-unflatmap
branch
from
29cce54
to
bcf69bf
Compare
|
Currently contains #470. |
felixfontein
force-pushed
the
prepare-unflatmap
branch
from
bcf69bf
to
f5a7970
Compare
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #472 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Add prefix to fixtures directory to avoid name-clashes when removing flatmapping. * Make sure string replacement works when automatically un-flatmapping. * Match filenames inside directories. (cherry picked from commit a1f1593)
|
@Andersson007 @russoz thanks a lot for reviewing this! |
felixfontein
added a commit
that referenced
this pull request
Oct 26, 2022
* Add prefix to fixtures directory to avoid name-clashes when removing flatmapping. * Make sure string replacement works when automatically un-flatmapping. * Match filenames inside directories. (cherry picked from commit a1f1593) Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prepares un-flatmapping. When collapsing the tests/unit/plugins/modules directory tree, there are some clashes because there are different
fixturesdirectories in the tree structure. This PR renames thesefixturesdirectories by prepending them with the module group names.Also removes some string wrapping so that automatic replacements work.
With these changes, https://gist.github.com/felixfontein/3123dcdf446c9e140949a0589cceb99d can remove flatmapping and at least the Python 3.10 unit tests still pass :)
Ref: ansible-community/community-topics#147
ISSUE TYPE
COMPONENT NAME
unit tests