Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added checking of available columns when receiving a subscription from the database #437

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Added checking of available columns when receiving a subscription from the database #437

merged 3 commits into from
Mar 30, 2023

Conversation

aleksvagachev
Copy link
Collaborator

SUMMARY

When an unprivileged user received a subscription, an error occurred: permission denied for table pg_subscription.
Now a check has been added, by getting the available columns and displaying only them.
Solution of the issue: #429

ISSUE TYPE

Feature Pull Request

@hunleyd hunleyd self-requested a review March 27, 2023 18:18
hunleyd
hunleyd requested changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@hunleyd hunleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, but pls fix the failing tests

jchancojr
jchancojr previously requested changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending @hunleyd suggestions

Andersson007
Andersson007 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant, thanks!

@hunleyd hunleyd dismissed jchancojr’s stale review March 30, 2023 18:54

pls re-review latest

@hunleyd hunleyd merged commit 5fa5334 into ansible-collections:main Mar 30, 2023
@patchback
Copy link

patchback bot commented Mar 30, 2023 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/5fa5334468b05a2117cb69c72e6f5ba8e63129a1/pr-437

Backported as #440

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2023
@aleksvagachev @patchback
Added checking of available columns when receiving a subscription fro…
ea00d50 
…m the database (#437)

Co-authored-by: aleksvagachev <aleksvagachev@yandex.ru>
(cherry picked from commit 5fa5334)
@patchback patchback bot mentioned this pull request Mar 30, 2023
Merged
@Andersson007
Copy link
Collaborator

thanks everyone for the contribution!

Andersson007 pushed a commit that referenced this pull request Apr 3, 2023
@patchback @aleksvagachev
Added checking of available columns when receiving a subscription fro…
c70fe13 
…m the database (#437) (#440)

Co-authored-by: aleksvagachev <aleksvagachev@yandex.ru>
(cherry picked from commit 5fa5334)

Co-authored-by: Aleks Vagachev <43969425+aleksvagachev@users.noreply.github.com>
@Andersson007 Andersson007 mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunleyd hunleyd hunleyd approved these changes

@Andersson007 Andersson007 Andersson007 approved these changes

@jchancojr jchancojr Awaiting requested review from jchancojr jchancojr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aleksvagachev @Andersson007 @hunleyd @jchancojr