Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt SNMP support #159

Merged
merged 4 commits into from Mar 11, 2023
Merged

Adapt SNMP support #159

merged 4 commits into from Mar 11, 2023

Conversation

phox142
Copy link
Contributor

@phox142 phox142 commented Mar 10, 2023

SUMMARY
  • add support for trap-interfaces in API paths snmp
  • add support for API paths snmp community
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • snmp
  • snmp community

@phox142 phox142 changed the title snmp support Adapt snmp support Mar 10, 2023
@phox142 phox142 changed the title Adapt snmp support Adapt SNMP support Mar 10, 2023
@phox142 phox142 marked this pull request as ready for review March 10, 2023 07:13
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #159 (7e7ff7b) into main (4d86ba1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files          30       30           
  Lines        3690     3690           
  Branches      673      673           
=======================================
  Hits         3191     3191           
  Misses        362      362           
  Partials      137      137           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 21.98% <ø> (ø)
units 86.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 96.92% <ø> (ø)
plugins/modules/api_info.py 90.14% <ø> (ø)
plugins/modules/api_modify.py 78.34% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks also for this contribution!

changelogs/fragments/159-snmp_community.yml Outdated Show resolved Hide resolved
changelogs/fragments/159-snmp_community.yml Outdated Show resolved Hide resolved
phox142 and others added 2 commits March 10, 2023 13:07
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 071f742 into ansible-collections:main Mar 11, 2023
@felixfontein
Copy link
Collaborator

@phox142 thanks again :)

@phox142
Copy link
Contributor Author

phox142 commented Mar 11, 2023

@felixfontein I'm trying to help the one whose development (time) I'm using ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants