Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration to temporarily disable the vars plugin (eg in AWX). #114

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

apollo13
Copy link
Contributor

Motivation

AWX stores all variables that it can parse which is very bad for security sensitive stuff :)

Changes description

I added a new env variable SOPS_ANSIBLE_AWX_DISABLE_VARS_PLUGIN_TEMPORARILY to disable the plugin temporarily. Can be used in AWX via a custom credential on the inventory source.

Additional notes

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #114 (dafdd82) into main (386377f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   65.30%   65.38%   +0.07%     
==========================================
  Files          10       10              
  Lines         957      959       +2     
  Branches      227      228       +1     
==========================================
+ Hits          625      627       +2     
  Misses        251      251              
  Partials       81       81              
Flag Coverage Δ
integration 64.57% <100.00%> (+0.07%) ⬆️
sanity 21.79% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/vars/sops.py 90.16% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

changelogs/fragments/114-disable-vars-plugin.yml Outdated Show resolved Hide resolved
plugins/vars/sops.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit e3d322d into ansible-collections:main Aug 23, 2022
@felixfontein
Copy link
Collaborator

@apollo13 thanks for contributing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants