Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml output on .yml files too #165

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Use yaml output on .yml files too #165

merged 3 commits into from
Oct 20, 2023

Conversation

applejag
Copy link
Contributor

Motivation

Closes #164

Changes description

  • Changed sops_encrypt module to also use yaml output on .yml files

Additional notes

@felixfontein
Copy link
Collaborator

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a481eee) 66.16% compared to head (8e2627f) 66.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          12       12           
  Lines         990      990           
  Branches      231      231           
=======================================
  Hits          655      655           
  Misses        255      255           
  Partials       80       80           
Flag Coverage Δ
integration 65.06% <100.00%> (ø)
sanity 22.52% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/modules/sops_encrypt.py 87.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@applejag
Copy link
Contributor Author

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

Added

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit b8af869 into ansible-collections:main Oct 20, 2023
60 checks passed
@felixfontein
Copy link
Collaborator

@applejag thanks a lot for your contribution!

@applejag applejag deleted the issue/164/yml-file-ending branch October 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't set --output-type yaml on .yml files, but only .yaml files
2 participants