Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vars plugin: allow to control staging and caching #32

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

felixfontein
Copy link
Collaborator

Staging allows to control when a vars plugin runs, see https://github.com/ansible/ansible/pull/61078/files for details.

Allowing to disable caching allows to modify vars files during the playbook, with the changes being available in the next run.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #32 into main will decrease coverage by 0.21%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   86.51%   86.29%   -0.22%     
==========================================
  Files           6        6              
  Lines         341      343       +2     
  Branches       60       61       +1     
==========================================
+ Hits          295      296       +1     
  Misses         32       32              
- Partials       14       15       +1     
Impacted Files Coverage Δ
plugins/vars/sops.py 87.71% <66.66%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe7a50...5b90482. Read the comment docs.

@felixfontein
Copy link
Collaborator Author

Restarting tests since ansible-test sanity should no longer fail for stable-2.9.

@felixfontein felixfontein merged commit 810b4c1 into ansible-collections:main Oct 28, 2020
@felixfontein felixfontein deleted the vars-staging branch October 28, 2020 11:54
@felixfontein
Copy link
Collaborator Author

@endorama thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants