Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sops_encrypt: YAML output type towards .yaml paths #56

Merged
merged 2 commits into from
Mar 5, 2021
Merged

sops_encrypt: YAML output type towards .yaml paths #56

merged 2 commits into from
Mar 5, 2021

Conversation

splushii
Copy link
Contributor

Signed-off-by: Christian Hernvall c.hernvall@yubico.com

Motivation

Use output_type yaml for sops_encrypt towards YAML files (*.yaml).

Changes description

See motivation.

Additional notes

First contribution to an Ansible community project. Let me know if I've missed something!

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #56 (9cc5559) into main (d941119) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   62.44%   62.30%   -0.14%     
==========================================
  Files           8        8              
  Lines         900      902       +2     
  Branches      201      202       +1     
==========================================
  Hits          562      562              
- Misses        260      261       +1     
- Partials       78       79       +1     
Impacted Files Coverage Δ
plugins/modules/sops_encrypt.py 80.00% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d941119...c0a3828. Read the comment docs.

@felixfontein
Copy link
Collaborator

@splushii thanks for your contribution!

Out of curiosity, in which circumstance is the explicit YAML output type needed?

In any case, this needs a changelog fragment.

@endorama
Copy link
Collaborator

endorama commented Mar 1, 2021

Hello @splushii, and welcome.

This changeset requires a Changelog fragment to be accepted. You can have a look at our CONTRIBUTING docs.

I'm curious too about the use case behind this implementation (documentation purposes only, I'm ok with it). @miono if you want to chip in, as you 👍 this, feel free to.

@splushii
Copy link
Contributor Author

splushii commented Mar 3, 2021

Hi! Thanks for the warm welcome! Sorry for the slow response!

This specific case is for the SOPS integration with FluxCD. In general anything that wants to read the YAML (which in the FluxCD case is about reading the unencrypted Kubernetes resource metadata without necessarily decrypting the whole sops file first).

Thanks for the pointers! I'll add a changelog fragment to the PR.

Signed-off-by: Christian Hernvall <c.hernvall@yubico.com>
@splushii
Copy link
Contributor Author

splushii commented Mar 5, 2021

@felixfontein @endorama a changelog fragment has been added.

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

@endorama what do you think about creating a new release after merging this? Ansible 3.1.0 will be released on Tuesday, so the new release will get included if we release it before then.

@endorama
Copy link
Collaborator

endorama commented Mar 5, 2021

@felixfontein Agreed, I'll do it.

@endorama endorama merged commit 9f1a95d into ansible-collections:main Mar 5, 2021
@endorama
Copy link
Collaborator

endorama commented Mar 5, 2021

@splushii thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants