Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make action_module plugin utils compatible with latest changes in ansible-core 2.11.0b3 #58

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

felixfontein
Copy link
Collaborator

Since we copied some code from community.crypto which was broken by a change in ansible-core 2.11.0b3, we also have to fix it there. This copies the fix from ansible-collections/community.crypto#202 to community.sops.

(For reference: ansible/ansible#73983)

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #58 (1c8106d) into main (22bc995) will increase coverage by 0.56%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   62.30%   62.87%   +0.56%     
==========================================
  Files           8        8              
  Lines         902      905       +3     
  Branches      202      206       +4     
==========================================
+ Hits          562      569       +7     
+ Misses        261      254       -7     
- Partials       79       82       +3     
Impacted Files Coverage Δ
plugins/plugin_utils/action_module.py 45.41% <78.26%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bc995...1c8106d. Read the comment docs.

@felixfontein
Copy link
Collaborator Author

Since this is identical to ansible-collections/community.crypto#202 and that one was already reviewed, I'm merging this one.

I'll create a new bugfix release of the collection from this today as well, so the latest release of the collection will again work with ansible/ansible's devel branch.

@felixfontein felixfontein merged commit 162456c into ansible-collections:main Mar 21, 2021
@felixfontein felixfontein deleted the action-module branch March 21, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant