Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ansible.module_utils._text by ansible.module_utils.common.text.converters #73

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

While the private API ansible.module_utils._text was the default place to get to_text, to_bytes and to_native for a long time, at least since Ansible 2.9 there's a non-private alternative: ansible.module_utils.common.text.converters. So let's use it :)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various plugins

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #73 (30e9aa8) into main (35e34d9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   64.27%   64.27%           
=======================================
  Files           9        9           
  Lines         946      946           
  Branches      217      217           
=======================================
  Hits          608      608           
  Misses        255      255           
  Partials       83       83           
Impacted Files Coverage Δ
plugins/action/load_vars.py 96.36% <100.00%> (ø)
plugins/filter/decrypt.py 94.87% <100.00%> (ø)
plugins/lookup/sops.py 100.00% <100.00%> (ø)
plugins/module_utils/sops.py 86.79% <100.00%> (ø)
plugins/modules/sops_encrypt.py 80.00% <100.00%> (ø)
plugins/plugin_utils/action_module.py 45.41% <100.00%> (ø)
plugins/vars/sops.py 88.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e34d9...30e9aa8. Read the comment docs.

Copy link

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit adaed57 into ansible-collections:main Jun 27, 2021
@felixfontein felixfontein deleted the text-conv branch June 27, 2021 14:17
@felixfontein
Copy link
Collaborator Author

@aminvakil thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants