Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest: Remove CD-ROM configuration as dict #1472

Closed
mariolenz opened this issue Sep 24, 2022 · 0 comments · Fixed by #1882
Closed

vmware_guest: Remove CD-ROM configuration as dict #1472

mariolenz opened this issue Sep 24, 2022 · 0 comments · Fixed by #1882
Assignees
@mariolenz
Labels
deprecated has_pr
Milestone
4.0.0

Comments

@mariolenz
Copy link
Collaborator

mariolenz commented Sep 24, 2022 •
edited

SUMMARY

Providing CD-ROM configuration as dict is deprecated and will be removed VMware collection 4.0.0.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

#317

community.vmware/plugins/modules/vmware_guest.py

Lines 341 to 345 in c660ecd

cdrom:
description:
- A list of CD-ROM configurations for the virtual machine. Added in version 2.9.
- Providing CD-ROM configuration as dict is deprecated and will be removed VMware collection 4.0.0.
Please use a list instead.

community.vmware/plugins/modules/vmware_guest.py

Lines 1400 to 1405 in c660ecd

def configure_cdrom_dict(self, vm_obj):
self.module.deprecate(
msg="Specifying CD-ROM configuration as dict is deprecated, Please use list to specify CD-ROM configuration.",
version="4.0.0",
collection_name="community.vmware"
)

@mariolenz mariolenz added this to the 4.0.0 milestone Sep 24, 2022
@mariolenz mariolenz mentioned this issue Oct 16, 2023
Merged
@mariolenz mariolenz self-assigned this Oct 16, 2023
softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 23, 2023
@mariolenz
vmware_guest: Remove CD-ROM configuration as dict (#1882)
136556d 
vmware_guest: Remove CD-ROM configuration as dict

SUMMARY
Fixes #1472
Removed specifying CDROM configuration as a dict, instead use a list.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
#317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariolenz mariolenz

Labels
deprecated has_pr
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

vmware_guest: Remove CD-ROM configuration as dict mariolenz/community.vmware
1 participant
@mariolenz