Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_dvs_portgroup: Fix idempotency #1286

Merged
merged 2 commits into from Apr 11, 2022
Merged

vmware_dvs_portgroup: Fix idempotency #1286

merged 2 commits into from Apr 11, 2022

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Apr 10, 2022 •
edited

SUMMARY

The parameter num_ports in vmware_dvs_portgroup is not required, but always used to test if a change is needed. This code will always trigger a change since None is different from the current number of ports, which is an integer:

community.vmware/plugins/modules/vmware_dvs_portgroup.py

Lines 711 to 713 in 5c15e55

# Check config
if self.dvs_portgroup.config.numPorts != self.module.params['num_ports']:
return 'update'

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_dvs_portgroup

ADDITIONAL INFORMATION

@mariolenz mariolenz closed this Apr 10, 2022
@mariolenz mariolenz reopened this Apr 10, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded.

@softwarefactory-project-zuul
Copy link

Build failed.

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@mariolenz mariolenz changed the title [WIP] vmware_dvs_portgroup: Fix idempotency vmware_dvs_portgroup: Fix idempotency Apr 11, 2022
@mariolenz mariolenz added bug This issue/PR relates to a bug mergeit labels Apr 11, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b456619 into ansible-collections:main Apr 11, 2022
@mariolenz mariolenz deleted the dvs_portgroup_idempotency branch April 12, 2022 18:54
@slauger slauger mentioned this pull request Jun 18, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mariolenz