Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added work through vCenter Server for #1799 #1832

Conversation

ihumster
Copy link
Collaborator

@ihumster ihumster commented Aug 27, 2023

SUMMARY

Fixes #1799

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_host_snmp

@softwarefactory-project-zuul
Copy link

@ihumster
Copy link
Collaborator Author

recheck

@ihumster
Copy link
Collaborator Author

recheck

@ihumster ihumster linked an issue Sep 23, 2023 that may be closed by this pull request
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already released 3.10.0 on Monday.

Sorry, I didn't find the time to have a closer look. Will try to do this soon.

plugins/modules/vmware_host_snmp.py Outdated Show resolved Hide resolved
plugins/modules/vmware_host_snmp.py Outdated Show resolved Hide resolved
@mariolenz
Copy link
Collaborator

I think we should have a few integration tests for this. I'll have a look at this.

@mariolenz
Copy link
Collaborator

I've tried to add some integration tests. Let's see what happens :-)

@ihumster
Copy link
Collaborator Author

LGTM

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the integration tests, configuring SNMP directly on an ESXi host and on an ESXi host / all hosts in a cluster through vCenter seem to work OK.

LGTM

Thanks @ihumster!

@mariolenz mariolenz added feature This issue/PR relates to a feature request has_issue mergeit labels Oct 13, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0dd061381c374cebad9f08ec643db838

✔️ ansible-tox-linters SUCCESS in 8m 26s
✔️ build-ansible-collection SUCCESS in 7m 31s
✔️ ansible-galaxy-importer SUCCESS in 5m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1699bcf into ansible-collections:main Oct 13, 2023
9 checks passed
@ihumster ihumster deleted the vmware_snmp_rework branch October 13, 2023 09:53
mariolenz pushed a commit to mariolenz/community.vmware that referenced this pull request Oct 13, 2023
…le-collections#1832)

added work through vCenter Server for ansible-collections#1799

SUMMARY
Fixes ansible-collections#1799
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_host_snmp

Reviewed-by: Mario Lenz <m@riolenz.de>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 13, 2023
stable-3.x: Configure SNMP for ESXi hosts via vCenter

SUMMARY
Configure SNMP for ESXi hosts via vCenter
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_host_snmp
ADDITIONAL INFORMATION
Backport of #1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_issue mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure SNMP for given ESXi hosts via vCenter
2 participants