vmware_vm_info: Fix AttributeError

[mariolenz]

SUMMARY

According to the documentation ipConfig in GuestNicInfo(vim.vm.GuestInfo.NicInfo) might be unset. This can lead to an AttributeError: 'NoneType' object has no attribute 'ipAddress'.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

I wasn't really able to reproduce this with:

• powered off VM
• powered on VM without VMware Tools installed
• powered on VM without VMware Tools installed and running
• powered on VM without VMware Tools installed and running, not all NICs configured

But it looks like some users run into this issue.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22aa241) 20.29% compared to head (7c53e93) 20.29%.
Report is 5 commits behind head on main.

❗ Current head 7c53e93 differs from pull request most recent head f036763. Consider uploading reports for the commit f036763 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   20.29%   20.29%   -0.01%     
==========================================
  Files         189      189              
  Lines       24582    24583       +1     
  Branches     5568     5569       +1     
==========================================
  Hits         4988     4988              
- Misses      19565    19566       +1     
  Partials       29       29              

Flag	Coverage Δ
sanity	19.02% <ø> (-0.01%)	⬇️
units	18.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/267d37c4d985465bbf84472fd0469040

✔️ ansible-tox-linters SUCCESS in 12m 42s
✔️ build-ansible-collection SUCCESS in 16m 19s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 21m 16s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 21m 33s
✔️ ansible-galaxy-importer SUCCESS in 5m 02s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/98b84847a8cb4c32b0daed628644fc63

✔️ ansible-tox-linters SUCCESS in 10m 40s
✔️ build-ansible-collection SUCCESS in 10m 58s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 20m 39s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 25m 19s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 1h 00m 23s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 57m 02s
✔️ ansible-galaxy-importer SUCCESS in 5m 05s

[mariolenz]

@AndrewSav Could you please test if this PR fixes your issue?

[AndrewSav]

@mariolenz Thank you for your work!

@AndrewSav Could you please test if this PR fixes your issue?

Is there a ansible-galaxy collection install I can execute to get the PR installed? We are running our playbooks on AWX in a custom execution environment image, and this command is how collections are getting installed there. I do not have another practical way of testing in other than building another EE image, and running it but I'm not sure how do I get this change into that image, can you advise?

[mariolenz]

Is there a ansible-galaxy collection install I can execute to get the PR installed?

No, there isn't. Since I couldn't reproduce your issue (and therefor don't know if this really fixes you issue without introducing another one) the idea is that you test the code before I merge and release it on galaxy.

One way to get this PR so you can test it might look like this:

mkdir -p  ~/.ansible/collections/ansible_collections/community
git clone https://github.com/ansible-collections/community.vmware ~/.ansible/collections/ansible_collections/community/vmware
cd ~/.ansible/collections/ansible_collections/community/vmware
git fetch origin pull/1919/head:20231113-vmware_vm_info
git checkout 20231113-vmware_vm_info

We are running our playbooks on AWX in a custom execution environment image, and this command is how collections are getting installed there. I do not have another practical way of testing in other than building another EE image, and running it but I'm not sure how do I get this change into that image, can you advise?

I don't know how to get the changes into AWX / an EE. I think AWX and testing upstream code changes are no friends... but I might be wrong there.

[AndrewSav]

the idea is that you test the code before I merge and release it on galaxy.

Thank you, a realize that. You can ran galaxy with as in ansible-galaxy install 'git+https:// - with git prefix for source, which would not require you to release in on galaxy, I was referring to this. Obviously if you have not tested this approach on this repo before we cannot be sure it would work, hence was my question.

I don't know how to get the changes into AWX / an EE. I think AWX and testing upstream code changes are no friends... but I might be wrong there.

You may well be right, but this is a practical issue, AWX provides a lot of infrastructure, such a secret and inventory management (inventory probably is not relevant in our context), so It can take significant amount of time even reproducing it outside it, let alone testing the patch. I really appreciate your work and I'm eager to test the fix, but I need to figure out how to do that. It can take awhile.

[AndrewSav]

@mariolenz we have tested this now and it does fix our issue. Thank you again!

[mariolenz]

@AndrewSav Thanks for testing!

You might have to wait two weeks or so for the next release, though.

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c24ccb219fd94429b52456088e53f576

✔️ ansible-tox-linters SUCCESS in 9m 59s
✔️ build-ansible-collection SUCCESS in 8m 14s
✔️ ansible-galaxy-importer SUCCESS in 5m 00s

[softwarefactory-project-zuul]

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f1925680a5f54e96987e9678976143d2

✔️ ansible-tox-linters SUCCESS in 10m 02s
✔️ build-ansible-collection SUCCESS in 11m 00s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 23m 06s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 21m 19s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 59m 04s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 47m 45s
✔️ ansible-galaxy-importer SUCCESS in 4m 58s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8d5d4ba139154e37afb798a6b6a879c4

✔️ ansible-tox-linters SUCCESS in 9m 49s
✔️ build-ansible-collection SUCCESS in 8m 20s
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

[softwarefactory-project-zuul]

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

[aseefahmed]

@mariolenz is there any ETA when its going to publish into galaxy?

[mariolenz]

There's no ETA. One or two weeks, I guess.

[sapanp007]

@mariolenz is it published into galaxy?

[mariolenz]

I would have liked to fix some more bugs and maybe implement some new features, but I'm afraid I didn't find the time.

Therefore, I've just released 4.0.1 to fix this at least. And yes @sapanp007, it's available on galaxy. Since a couple of minutes...