Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest_info: Handle list in guest facts #36

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 5, 2020

SUMMARY

Handle list items in vSphere schema while handling facts in vmware_guest_info

Fixes: #33

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/33-vmware_guest_info_list_fix.yml
plugins/module_utils/vmware.py
tests/integration/targets/vmware_guest_info/tasks/main.yml

Copy link
Member

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary a request for change, but I'm not sure I fully understand the impact of the change.

@@ -0,0 +1,2 @@
bugfixes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more a minor_changes IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bugfix since user specified property is a list and module API is not handling it properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarifiation.

changelogs/fragments/33-vmware_guest_info_list_fix.yml Outdated Show resolved Hide resolved
Handle list items in vSphere schema while handling facts in vmware_guest_info

Fixes: ansible-collections#33

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@goneri goneri added the gate label Mar 9, 2020
@ansible-zuul ansible-zuul bot merged commit efe6bd4 into ansible-collections:master Mar 9, 2020
@Akasurde Akasurde deleted the i33 branch October 29, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmware_guest_info: Failed to gather information with vSphere Schema
2 participants