vmware_guest_network: Fix to port group changes to work properly #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2020
|
LGTM |
|
@mariolenz Do you think we can go ahead and merge this? Thanks. |
I successfully ran some test playbooks in our environment and the code changes make sense to me. So I'd say: Yes, go ahead. |
|
@mariolenz Thanks for the heads-up and feedback. |
|
Thank you @mariolenz @Akasurde ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix to port group changes to work properly.
The vmware_guest_network module has been an error that occurs or can't change the port group when changing the port group.
The cause of the error is each object type didn't compare well, wronged object structure.
This PR is to fix that bug.
And NSX-T port group supported.
fixes: #88 #204 #339 #352
ISSUE TYPE
COMPONENT NAME
plugins/modules/vmware_guest_network.py
ADDITIONAL INFORMATION
tested on vCenter/ESXi 7.0/6.7 and NSX-T 3.0