Include SELinux tasks for zabbix_web and refactor selinux variable names #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable names. Selinux tasks were not included by zabbix_web role, seems that include had been dropped by accident (?) on pull request ansible-collections#979 (v2.0.0) Restored `include_tasks: selinux.yml` to roles/zabbix_web/tasks/RedHat.yml Refactor `zabbix_selinux` variable to `zabbix_web_selinux` as variable names should be prefixed with role name, also to use similar pattern with `zabbix_proxy_selinux` and `zabbix_server_selinux` variables. Refactor `selinux_allow_*` variable names to correlate with selinux boolean names. Refactor `zabbix_apache_can_connect_ldap` to `selinux_allow_httpd_can_connect_ldap` as it's not apache specific and not correlating with actual seboolean name.
pyrodie18
requested changes
May 7, 2024
pyrodie18
approved these changes
May 9, 2024
pyrodie18
pushed a commit
to pyrodie18/community.zabbix
that referenced
this pull request
May 14, 2024
…mes (ansible-collections#1220) * Include missing SELinux tasks from selinux.yml and refactor selinux variable names. Selinux tasks were not included by zabbix_web role, seems that include had been dropped by accident (?) on pull request ansible-collections#979 (v2.0.0) Restored `include_tasks: selinux.yml` to roles/zabbix_web/tasks/RedHat.yml Refactor `zabbix_selinux` variable to `zabbix_web_selinux` as variable names should be prefixed with role name, also to use similar pattern with `zabbix_proxy_selinux` and `zabbix_server_selinux` variables. Refactor `selinux_allow_*` variable names to correlate with selinux boolean names. Refactor `zabbix_apache_can_connect_ldap` to `selinux_allow_httpd_can_connect_ldap` as it's not apache specific and not correlating with actual seboolean name. --------- Co-authored-by: Miikka Joutsenvirta <miikka@joutsenvirta.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Selinux tasks were not included by zabbix_web role,
seems that include had been dropped by accident (?) on pull request #979 (v2.0.0)
Restored
include_tasks: selinux.ymlto roles/zabbix_web/tasks/RedHat.ymlRefactor
zabbix_selinuxvariable tozabbix_web_selinuxas variable names should be prefixed with role name,also to use similar pattern with
zabbix_proxy_selinuxandzabbix_server_selinuxvariables.Refactor selinux related variable names in zabbix_web role to correlate with selinux boolean names.
Refactor
zabbix_apache_can_connect_ldaptoselinux_allow_httpd_can_connect_ldapas it's not apache specific and not correlating with actual selinux boolean name.
Don't set zabbix_can_network boolean in zabbix_web role as it's not relevant (AFAIK).
ISSUE TYPE
COMPONENT NAME
zabbix_web