Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix_agent - Use zabbix_agent_distribution_release to backport packages #1240

Conversation

kivilahtio
Copy link

SUMMARY

Configuration 'zabbix_agent_distribution_release' is already defined in the role. Actually make it usable to overload the system's ansible_distribution_release. This is useful to for example install Zabbix Agent2 on Raspbian 12 Bookworm using the older packages, as there is not release for the specific target distribution and version.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Zabbix Agent

ADDITIONAL INFORMATION

…ages

Configuration 'zabbix_agent_distribution_release' is already defined in the role.
Actually make it usable to overload the system's ansible_distributin_release.
This is useful to for example install Zabbix Agent2 on Raspbian 12 Bookworm using
the older packages.
@kivilahtio
Copy link
Author

Unrelated to this:
I delivered a PR to address an architecture issue I encountered with the Raspbian support:

#1060

It is closed, but maybe it can be reopened to continue the discussion as there is an update to the previously fixed issue?

@pyrodie18
Copy link
Collaborator

I don't see where zabbix_agent_distribution_release is defined anywhere.

@kivilahtio
Copy link
Author

I don't see where zabbix_agent_distribution_release is defined anywhere.

commit f008e17
Author: Werner Dijkerman werner.dijkerman@iwelcome.com
Date: Tue Jun 9 19:02:50 2020 +0200

As it provides error while using a dash (-) in the role name, we will use an underscore (_)

file: roles/zabbix_agent/defaults/main.yml

@@ -61,7 +61,7 @@
Types: deb{{ ' deb-src' if zabbix_repo_deb_include_deb_src }}
Enabled: yes
URIs: {{ zabbix_repo_deb_url }}
Suites: {{ ansible_distribution_release }}
Suites: {{ zabbix_agent_distribution_release }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no default provided for this, it's gonna break for everyone that hasn't defined this variable. It was cleaned out by c2a32d5

@eb4x
Copy link
Contributor

eb4x commented May 31, 2024

Unrelated to this: I delivered a PR to address an architecture issue I encountered with the Raspbian support:
#1060
It is closed, but maybe it can be reopened to continue the discussion as there is an update to the previously fixed issue?

I think you'll find that #1225 fixes what #1060 wanted to do. But you're probably right that Suites: should be based on the lsb.id.

That's not what's going down in this PR though, you'll have to update to reflect the newest changes.

@eb4x
Copy link
Contributor

eb4x commented May 31, 2024

But you're probably right that Suites: should be based on the lsb.id.

Actually, it should probably just say zabbix here? Looking at https://repo.zabbix.com/zabbix/6.4/raspbian/dists/bullseye/Release Suite: zabbix, or maybe it doesn't really matter?

@BGmot
Copy link
Collaborator

BGmot commented Jul 6, 2024

@kivilahtio are you still wanting to pursue this?

@kivilahtio
Copy link
Author

@kivilahtio are you still wanting to pursue this?

Not at them moment.
Hopefully #1225 will fix it

@BGmot BGmot closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants