Fix windows agent installation #1300 #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrodie18
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Thanks for that. Only thing I say that needs to be changed. Undo your change to changelog.yml and instead follow the instructions at https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment for putting in a change fragement.
|
@david-sieg you're failing sanity checks. I'm guessing you're on a Windows system which by default uses a combined /r/n for new lines instead of the /n by itself that *Nix uses. This in the change fragment is causing it to fail. Also the format for the change fragment is |
pyrodie18
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Extend when condition for Docker and Windows.
ISSUE TYPE
COMPONENT NAME
include_role
ADDITIONAL INFORMATION
This PR should fix #1300