Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database import script location (& whitespace) #342

Conversation

ChandlerSwift
Copy link
Contributor

SUMMARY

Zabbix 3.0 (currently supported) and 3.2 (now unsupported) placed
import scripts at
/usr/share/doc/zabbix-server-{mysql,pgsql}-{3.0.0,3.2.0}/create.sql.gz,
while newer versions (3.4, 4.x, 5.x) have scripts at
/usr/share/doc/zabbix-server-{mysql,pgsql}/create.sql.gz.

References for currently supported versions:
3.0: https://www.zabbix.com/documentation/3.0/manual/installation/install_from_packages/server_installation_with_mysql#creating_initial_database
4.0: https://www.zabbix.com/documentation/4.0/manual/installation/install_from_packages/rhel_centos#importing_data
5.0: https://www.zabbix.com/download?zabbix=5.0&os_distribution=red_hat_enterprise_linux&os_version=8&db=mysql
5.2: https://www.zabbix.com/download?zabbix=5.2&os_distribution=red_hat_enterprise_linux&os_version=8&db=mysql

This commit should make all versions since 3.0 work (this includes all
supported versions.)

Even older (unsupported) versions had additional locations, but this
commit does not include support for those versions. For example, Zabbix
2.0 had scripts in a further subdirectory at
/usr/share/doc/zabbix-server-mysql-2.4.0/create
(https://www.zabbix.com/documentation/2.4/manual/installation/install_from_packages#creating_initial_database)
with three separate scripts; this would break assumptions made elsewhere
in this module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix_server role

@ChandlerSwift ChandlerSwift force-pushed the fix-server-database-script-locations branch from 87fd54b to 27c8aff Compare March 12, 2021 23:10
@ChandlerSwift
Copy link
Contributor Author

D'oh! I started with an earlier version of this commit. Fixed!

Zabbix 3.0 (currently supported) and 3.2 (now unsupported) placed
import scripts at
/usr/share/doc/zabbix-server-{mysql,pgsql}-{3.0.0,3.2.0}/create.sql.gz,
while newer versions (3.4, 4.x, 5.x) have scripts at
/usr/share/doc/zabbix-server-{mysql,pgsql}/create.sql.gz.

References for currently supported versions:
3.0: https://www.zabbix.com/documentation/3.0/manual/installation/install_from_packages/server_installation_with_mysql#creating_initial_database
4.0: https://www.zabbix.com/documentation/4.0/manual/installation/install_from_packages/rhel_centos#importing_data
5.0: https://www.zabbix.com/download?zabbix=5.0&os_distribution=red_hat_enterprise_linux&os_version=8&db=mysql
5.2: https://www.zabbix.com/download?zabbix=5.2&os_distribution=red_hat_enterprise_linux&os_version=8&db=mysql

This commit should make all versions since 3.0 work (this includes all
supported versions.)

Even older (unsupported) versions had additional locations, but this
commit does not include support for those versions. For example, Zabbix
2.0 had scripts in a further subdirectory at
/usr/share/doc/zabbix-server-mysql-2.4.0/create
(https://www.zabbix.com/documentation/2.4/manual/installation/install_from_packages#creating_initial_database)
with three separate scripts; this would break assumptions made elsewhere
in this module.
@D3DeFi
Copy link
Collaborator

D3DeFi commented Mar 13, 2021

thank you for your commit, can you please rebase this patch on top of now merged #345 into the main?

git fetch upstream
git rebase upstream/main
git push origin -f mybranch

@D3DeFi D3DeFi added the role The issue or pull request is related to Zabbix role label Mar 13, 2021
@ChandlerSwift ChandlerSwift force-pushed the fix-server-database-script-locations branch from 27c8aff to 488b520 Compare March 17, 2021 01:57
@dj-wasabi dj-wasabi merged commit 248e9f7 into ansible-collections:main Mar 28, 2021
@dj-wasabi
Copy link
Collaborator

Thanks! 👍

@ChandlerSwift ChandlerSwift deleted the fix-server-database-script-locations branch July 10, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role The issue or pull request is related to Zabbix role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants