Allow updating hcloud_server_network (alias IPs) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKaemmerling
force-pushed
the
hcloud_server_network_change_alias_ips
branch
from
3c2b775
to
0a906ef
Compare
Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
LKaemmerling
force-pushed
the
hcloud_server_network_change_alias_ips
branch
from
0a906ef
to
b917b49
Compare
fhofherr
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukas Kämmerling lukas.kaemmerling@hetzner-cloud.de
SUMMARY
This MR allows updating hcloud_server_network. Only alias IPs are updateable, all the other values are not updateable without reattachment (deleting hcloud_server_network)
Fixes #40
ISSUE TYPE
COMPONENT NAME
hcloud_server_network
ADDITIONAL INFORMATION