Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community.kubevirt collection is totally broken because of changes related to this collection #219

Closed
Andersson007 opened this issue Sep 1, 2021 · 3 comments
Closed

community.kubevirt collection is totally broken because of changes related to this collection #219

Andersson007 opened this issue Sep 1, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Andersson007
Copy link
Contributor

Andersson007 commented Sep 1, 2021 •
edited by gundalow

SUMMARY

Now the community.kubevirt collection is totally broken.

It has the community.kubernetes collection as a dependency.

If we change imports, etc to kubernetes.core like in ansible-collections/community.kubevirt#23, it starts failing because of the code changes here.

For example (these only sanity failures; units and integration are also broken)

Running sanity test 'import' with Python 2.6
ERROR: Found 7 import issue(s) on python 2.6 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_cdi_upload.py:82:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_preset.py:91:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_pvc.py:253:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_rs.py:110:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_template.py:204:0: traceback: ImportError: No module named orderreddict
ERROR: plugins/modules/kubevirt_vm.py:248:0: traceback: ImportError: No module named orderreddict
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
Running sanity test 'import' with Python 2.7
ERROR: Found 7 import issue(s) on python 2.7 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name list_dict_str
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ImportError: No module named raw
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name list_dict_str (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ImportError: No module named raw
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name list_dict_str (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name list_dict_str (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name list_dict_str (at plugins/module_utils/kubevirt.py:14:0)
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
Running sanity test 'import' with Python 3.5
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
ERROR: Found 7 import issue(s) on python 3.5 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name 'list_dict_str'
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ImportError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ImportError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
Running sanity test 'import' with Python 3.6
ERROR: Found 7 import issue(s) on python 3.6 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name 'list_dict_str'
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name 'list_dict_str' (at plugins/module_utils/kubevirt.py:14:0)
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
Running sanity test 'import' with Python 3.7
ERROR: Found 7 import issue(s) on python 3.7 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py)
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
Running sanity test 'import' with Python 3.8
ERROR: Found 7 import issue(s) on python 3.8 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py)
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/import.html
Running sanity test 'import' with Python 3.9
ERROR: Found 7 import issue(s) on python 3.9 which need to be resolved:
ERROR: plugins/module_utils/kubevirt.py:14:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py)
ERROR: plugins/modules/kubevirt_cdi_upload.py:83:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_preset.py:93:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_pvc.py:254:0: traceback: ModuleNotFoundError: No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw'
ERROR: plugins/modules/kubevirt_rs.py:112:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_template.py:206:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)
ERROR: plugins/modules/kubevirt_vm.py:249:0: traceback: ImportError: cannot import name 'list_dict_str' from 'ansible_collections.kubernetes.core.plugins.module_utils.common' (/root/ansible_collections/kubernetes/core/plugins/module_utils/common.py) (at plugins/module_utils/kubevirt.py:14:0)

Running sanity test 'validate-modules' with Python 3.6
See documentation for help: https://docs.ansible.com/ansible/2.10/dev_guide/testing/sanity/validate-modules.html
ERROR: Found 6 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/kubevirt_cdi_upload.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw''
ERROR: plugins/modules/kubevirt_preset.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'cannot import name 'list_dict_str''
ERROR: plugins/modules/kubevirt_pvc.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible_collections.kubernetes.core.plugins.module_utils.raw''
ERROR: plugins/modules/kubevirt_rs.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'cannot import name 'list_dict_str''
ERROR: plugins/modules/kubevirt_template.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'cannot import name 'list_dict_str''
ERROR: plugins/modules/kubevirt_vm.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'cannot import name 'list_dict_str''
Running sanity test 'yamllint' with Python 3.6
ERROR: The 8 sanity test(s) listed below (out of 45) failed. See error output above for details.

If someone can take a look, it would be great.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

community.kubevirt collection
@Andersson007 Andersson007 added the help wanted Extra attention is needed label Sep 1, 2021
@Andersson007
Copy link
Contributor Author

cc @gundalow FYI

This was referenced Sep 1, 2021
Closed
Closed
@Andersson007
Copy link
Contributor Author

ansible-collections/community.kubevirt#25
ansible-collections/community.kubevirt#26

@Andersson007
Copy link
Contributor Author

Closed via ansible-collections/community.kubevirt#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andersson007