New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename k8s dependency #25
Rename k8s dependency #25
Conversation
f272cbf
to
df9c391
Compare
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 62.31% 60.98% -1.34%
==========================================
Files 11 10 -1
Lines 820 733 -87
Branches 146 131 -15
==========================================
- Hits 511 447 -64
+ Misses 253 238 -15
+ Partials 56 48 -8
Continue to review full report at Codecov.
|
e5d078e
to
0af7ffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about we make following changes -
- community.kubevirt 1.* depends upon community.kubernetes 1.*
- a major release like 2.0 and making it dependent on kubernetes.core 2.0
From IRC:
I just wanted to make sure communty.kubevirt does work with properly restricted kubernetes.core, but as state above, if someone has time to actually fix the collection and make it work with k.c 2.x.y, even better. |
@tadeboro folks will discuss which way to follow and will put something in here soon, thank you! |
The community.kubernetes collection has been renamed to kubernetes.core and this commit just makes sure the collection will not get stuck with the old name.
0af7ffa
to
e9b159e
Compare
Hi there, I read there were plans to move away from community.k8s to core.k8s. This sounds important to me since with community.k8s we're stuck on this issue and forced to keep Could someone give me a status on this ? Thanks. |
@jseguillon hi, thanks for asking! |
@jseguillon moreover, as the collection is unmaintained and is broken in Ansible 5, it's going to be removed from the package (we are developing the process now ansible-collections/overview#201). |
Closing since collection is dying. |
@tadeboro thanks! |
The community.kubernetes collection has been renamed to kubernetes.core and this commit just makes sure the collection will not get stuck with the old name.
Do note that we had to introduce an upper bound in the requirements since the kubernetes.core broke backward compatibility with version 2.0.0.
Depends on #26ISSUE TYPE