Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to pass command line args to Kustomize to install helm charts #568

Closed
rkesters opened this issue Jan 19, 2023 · 2 comments · Fixed by #592
Closed

Need to pass command line args to Kustomize to install helm charts #568

rkesters opened this issue Jan 19, 2023 · 2 comments · Fixed by #592
Labels
topic/helm Issues relating to helm plugins type/enhancement New feature or request

Comments

@rkesters
Copy link

SUMMARY

I need to pass command line args to kustomize, current implmentation does not allow this.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

kubernetes.core.kustomize

ADDITIONAL INFORMATION

My project use Kustomize to install services into the cluster, we would like to install helm charts via Kustomize but the ansible kustomize does not allow us to pass the --enable-helm arg.

@tima
Copy link
Collaborator

tima commented Jan 19, 2023

Thanks @rkesters. Seems reasonable. Submit a PR and we'll review it for the next release.

@tima tima added type/enhancement New feature or request topic/helm Issues relating to helm plugins labels Jan 19, 2023
@apinter
Copy link

apinter commented Dec 4, 2023

Thanks @rkesters. Seems reasonable. Submit a PR and we'll review it for the next release.

A PR (#592) has indeed been submitted for a while now which actually helped me last week to deploy a new env with Ansible and the k8s collection. I can patch things downstream, but I think merging this change would be pretty great upstream.

softwarefactory-project-zuul bot pushed a commit that referenced this issue May 13, 2024
Update kustomize.py add --enable-helm support

Add --enable-helm support
SUMMARY
Fixes #568
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Lookup plugin: kubernetes.core.kustomize
ADDITIONAL INFORMATION
Current and maintained arg:
lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:
lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

Reviewed-by: Mike Graves <mgraves@redhat.com>
patchback bot pushed a commit that referenced this issue May 13, 2024
Update kustomize.py add --enable-helm support

Add --enable-helm support
SUMMARY
Fixes #568
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Lookup plugin: kubernetes.core.kustomize
ADDITIONAL INFORMATION
Current and maintained arg:
lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:
lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit 0408aa9)
softwarefactory-project-zuul bot pushed a commit that referenced this issue May 13, 2024
[PR #592/0408aa93 backport][stable-3] Update kustomize.py add --enable-helm support

This is a backport of PR #592 as merged into main (0408aa9).
Add --enable-helm support
SUMMARY
Fixes #568
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Lookup plugin: kubernetes.core.kustomize
ADDITIONAL INFORMATION
Current and maintained arg:
lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:
lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

Reviewed-by: Mike Graves <mgraves@redhat.com>
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this issue May 19, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[kubernetes.core](https://togithub.com/ansible-collections/kubernetes.core)
| galaxy-collection | minor | `3.0.1` -> `3.1.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ansible-collections/kubernetes.core (kubernetes.core)</summary>

###
[`v3.1.0`](https://togithub.com/ansible-collections/kubernetes.core/blob/HEAD/CHANGELOG.rst#v310)

[Compare
Source](https://togithub.com/ansible-collections/kubernetes.core/compare/3.0.1...3.1.0)

\======

## Release Summary

This release comes with some bugfixes and documentation updates. It also
adds new features to the kubectl connection plugin and the kustomize
lookup plugin.

## Minor Changes

- kubectl - added support of local enviroment variable that will be used
for kubectl and may be requried for establishing connections ifself
([ansible-collections/kubernetes.core#702)
- kustomize - new parameter added to --enable-helm
([ansible-collections/kubernetes.core#568)

## Bugfixes

- helm - expand kubeconfig path with user's home directory for
consistency with k8s
- k8s_json_patch - rename action symlink to ensure k8s action plugin is
used
([ansible-collections/kubernetes.core#652).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9hbnNpYmxlIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/helm Issues relating to helm plugins type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants