Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sinceSeconds parameter to k8s_logs #142

Merged
merged 8 commits into from
Jul 15, 2021

Conversation

stg-0
Copy link
Contributor

@stg-0 stg-0 commented Jun 21, 2021

SUMMARY

This simple PR aims to add the sinceSeconds API's parameter to the k8s_log module so we can limit the output since it can be huge in some cases.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

k8s_log

ADDITIONAL INFORMATION

stg-0 and others added 2 commits June 22, 2021 14:29
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@gravesm
Copy link
Member

gravesm commented Jun 22, 2021

@stg-0 Thanks for the PR! The rst docs will be auto-generated from the module docs so you can remove that file. You should update one of the examples in the k8s_log.py module file instead.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #142 (8ca5321) into main (2594ac6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2594ac6...8ca5321. Read the comment docs.

plugins/modules/k8s_log.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Graves <mgraves@redhat.com>
@stg-0 stg-0 requested a review from gravesm June 29, 2021 08:30
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stg-0!

@Akasurde Akasurde merged commit 2e98493 into ansible-collections:main Jul 15, 2021
@Akasurde
Copy link
Member

@stg-0 Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants