Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for in-memory kubeconfig #212

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Aug 26, 2021

SUMMARY

k8s module support now authentication with kubeconfig parameter as file and dict.

Closes #139

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@abikouo abikouo closed this Aug 26, 2021
@abikouo abikouo reopened this Aug 26, 2021
@abikouo abikouo closed this Aug 26, 2021
@abikouo abikouo reopened this Aug 26, 2021
@gravesm
Copy link
Member

gravesm commented Aug 26, 2021

load_kube_config_from_dict() was not added until v17.17 of kubernetes. We'll need to both document that this feature will only work on that version or later, and provide a more friendly error message when they try to use it on an older version.

Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small doc change request but otherwise this looks good.

plugins/doc_fragments/k8s_auth_options.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Graves <mgraves@redhat.com>
@abikouo abikouo closed this Aug 27, 2021
@abikouo abikouo reopened this Aug 27, 2021
@abikouo
Copy link
Contributor Author

abikouo commented Aug 27, 2021

recheck

Copy link

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in-memory kubeconfig rather than file
2 participants